Skip to content

Match AIR snapshot and workspace resolution - #6413

Open
ben-hansen-db wants to merge 2 commits into
mainfrom
ben-hansen/air-snapshot-workspace-parity
Open

Match AIR snapshot and workspace resolution#6413
ben-hansen-db wants to merge 2 commits into
mainfrom
ben-hansen/air-snapshot-workspace-parity

Conversation

@ben-hansen-db

@ben-hansen-db ben-hansen-db commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Evaluate snapshot ignores through Git, including nested rules and negations.
  • Skip deleted tracked files while preserving symlinks and mandatory exclusions.
  • Resolve the AIR workspace directory from environment, selected profile, or user identity.

Why

Match Python snapshot and workspace-directory behavior without adding remote Git support.

Tests

  • go test ./experimental/air/cmd
  • go test ./libs/databrickscfg

This PR was written with Codex.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: a880d68

Run: 33139318535

Env 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 1 1 274 1194 3:52
💚​ aws windows 1 1 276 1192 3:34
💚​ azure linux 1 1 273 1194 3:50
💚​ azure windows 1 1 275 1192 3:28
💚​ gcp linux 1 1 274 1194 4:11
💚​ gcp windows 1 1 276 1192 4:18
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
Top 3 slowest tests (at least 2 minutes):
duration env testname
4:13 gcp windows TestAccept
3:30 aws windows TestAccept
3:23 azure windows TestAccept

@ben-hansen-db
ben-hansen-db force-pushed the ben-hansen/air-snapshot-workspace-parity branch from 29c379d to 6ba3037 Compare August 27, 2026 23:37
@ben-hansen-db
ben-hansen-db changed the base branch from ben-hansen/air-submission-yaml-parity to main August 27, 2026 23:37
@ben-hansen-db
ben-hansen-db force-pushed the ben-hansen/air-snapshot-workspace-parity branch from 6ba3037 to bdea497 Compare August 27, 2026 23:42
@ben-hansen-db
ben-hansen-db marked this pull request as ready for review August 27, 2026 23:50
@github-actions

github-actions Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Approval status: pending

/experimental/air/ - approved by @vinchenzo-db

4 files changed

/libs/databrickscfg/ - needs approval

Files: libs/databrickscfg/profile_value.go, libs/databrickscfg/profile_value_test.go
Suggested: @simonfaltum
Also eligible: @renaudhartert-db, @tanmay-db, @Divyansh-db, @mihaimitrea-db, @tejaskochar-db, @hectorcast-db, @parthban-db, @chrisst, @rauchy

General files (require maintainer)

Files: .nextchanges/cli/air-snapshot-profile-parity.md
Based on git history:

  • @simonfaltum -- recent work in libs/databrickscfg/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinchenzo-db vinchenzo-db vinchenzo-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ben-hansen-db @eng-dev-ecosystem-bot @vinchenzo-db